fix(ui): preview mode show the pr number by btea · Pull Request #2018 · npmx-dev/npmx.dev

btea · 2026-03-10T06:20:09Z

🔗 Linked issue

🧭 Context

#1729 Mobile devices are not handled.

📚 Description

vercel · 2026-03-10T06:20:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ready	Preview, Comment	Mar 21, 2026 2:35am
npmx.dev	Ready	Preview, Comment	Mar 21, 2026 2:35am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
npmx-lunaria	Ignored		Mar 21, 2026 2:35am

codecov · 2026-03-10T06:22:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

coderabbitai · 2026-03-10T06:24:09Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 396ec548-cfbe-4493-9bea-0555e54accf6

📥 Commits

Reviewing files that changed from the base of the PR and between e610314 and 3a21abd.

📒 Files selected for processing (4)

app/components/AppHeader.vue
i18n/locales/en.json
i18n/locales/zh-CN.json
i18n/schema.json

🚧 Files skipped from review as they are similar to previous changes (2)

i18n/locales/en.json
app/components/AppHeader.vue

📝 Walkthrough

Walkthrough

Modifies AppHeader.vue: removes the previous desktop PR link that rendered whenever prNumber was truthy; adds a PR badge/link that renders only when showLogo is true, !isSearchExpanded and prNumber is truthy; changes the PR link aria-label to use $t('header.pr', { prNumber }); and removes the explicit ms-2 margin class from the badge. Adds the header.pr translation key to i18n/locales/en.json and i18n/locales/zh-CN.json, and registers header.pr in i18n/schema.json.

Possibly related PRs

feat: preview mode show the pr number #1729: Modifies the GitHub PR badge/link in AppHeader.vue, touching rendering conditions and translation/aria-label usage for the PR link.
fix(ui): improve logo #1770: Changes the AppHeader.vue logo/badge block markup and classes, affecting badge rendering and positioning in the same component.

Suggested reviewers

danielroe
alexdln

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description references issue `#1729` about mobile device handling, which aligns with the code changes that relocate and conditionally display the PR badge to be visible on mobile when search is not expanded.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2637e916-c5c3-4b24-ad6c-535dcfbf0a80

📥 Commits

Reviewing files that changed from the base of the PR and between 99c9533 and ffa05b4.

📒 Files selected for processing (1)

app/components/AppHeader.vue

app/components/AppHeader.vue

github-actions · 2026-03-10T07:01:18Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
i18n/locales/en.json	Source changed, localizations will be marked as outdated.
i18n/locales/zh-CN.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

serhalp · 2026-03-15T14:46:54Z

app/components/AppHeader.vue

+        class="sm:hidden"
+      >
+        <span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
+          PR #{{ prNumber }}


if we're internationalizing this feature, maybe "PR" should be translated as well?

IMO, those who see this information on the page are usually redirected through a Premiere Pro (PR) preview link. I assume that those familiar with these operations are developers, and based on this assumption, PR seems to be a very clear abbreviation, so I don't think it needs to be translated.

Of course, if you feel this reason is insufficient, we can continue to discuss it.

Premiere Pro

What xD

if we're internationalizing this feature, maybe "PR" should be translated as well?

I think it's ok not being translated, I couldn't find it anywhere else translated, or with the current desktop version of this feature - but we can always translate it in a follow up!

fix(ui): preview mode show the pr number

ffa05b4

vercel bot deployed to Preview – npmx.dev March 10, 2026 06:22 View deployment

coderabbitai bot reviewed Mar 10, 2026

View reviewed changes

app/components/AppHeader.vue Outdated Show resolved Hide resolved

app/components/AppHeader.vue Outdated Show resolved Hide resolved

feat: apply review

4715ebc

vercel bot deployed to Preview – npmx.dev March 10, 2026 07:02 View deployment

serhalp reviewed Mar 15, 2026

View reviewed changes

ghostdevv added 2 commits March 20, 2026 00:42

fix: remove extra spacing

c39ce27

refactor: reduce duplication

e610314

vercel bot deployed to Preview – npmx.dev March 20, 2026 07:54 View deployment

Merge branch 'main' into fix/mobile-show-pr-number

3a21abd

vercel bot deployed to Preview – docs.npmx.dev March 21, 2026 02:35 View deployment

vercel bot deployed to Preview – npmx.dev March 21, 2026 02:35 View deployment

ghostdevv approved these changes Mar 21, 2026

View reviewed changes

ghostdevv added this pull request to the merge queue Mar 21, 2026

Merged via the queue into npmx-dev:main with commit c45e5ef Mar 21, 2026
20 checks passed

github-actions bot mentioned this pull request Mar 21, 2026

chore: release v0.5.0 #2096

Open

btea deleted the fix/mobile-show-pr-number branch March 21, 2026 02:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ui): preview mode show the pr number#2018

fix(ui): preview mode show the pr number#2018
ghostdevv merged 5 commits intonpmx-dev:mainfrom
btea:fix/mobile-show-pr-number

btea commented Mar 10, 2026

Uh oh!

vercel bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

serhalp Mar 15, 2026

Uh oh!

btea Mar 16, 2026

Uh oh!

ghostdevv Mar 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

btea commented Mar 10, 2026

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercel bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 10, 2026

Codecov Report

Uh oh!

coderabbitai bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

serhalp Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

btea Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostdevv Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Mar 10, 2026 •

edited

Loading

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

github-actions bot commented Mar 10, 2026 •

edited

Loading